Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add if*generation*match support for Bucket.rename_blob() #141

Merged
merged 19 commits into from Jun 9, 2020

Conversation

IlyaFaer
Copy link

Towards #127

@IlyaFaer IlyaFaer added api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 12, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2020
@IlyaFaer IlyaFaer requested review from frankyn and andrewsg May 13, 2020 09:11
@IlyaFaer IlyaFaer marked this pull request as ready for review May 13, 2020 09:11
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@frankyn frankyn merged commit f52efc8 into googleapis:master Jun 9, 2020
@IlyaFaer IlyaFaer deleted the blob_rename_generation_match branch June 10, 2020 07:27
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…eapis#141)

* feat: add ifMetageneration*Match support, pt1

* fix unit tests, add test for helper

* fix unit tests

* add generation match args into more methods

* feat: add if*generation*Match support, pt2

* Lint fix.

* delete "more than one set "checks

* del excess import

* delete "more than one set" checks

* rename the helper; add error raising in case of wront parameters type

* feat: add if*generation*match support for Bucket.rename_blob()

* erase resolving conflicts caused blank line

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…eapis#141)

* feat: add ifMetageneration*Match support, pt1

* fix unit tests, add test for helper

* fix unit tests

* add generation match args into more methods

* feat: add if*generation*Match support, pt2

* Lint fix.

* delete "more than one set "checks

* del excess import

* delete "more than one set" checks

* rename the helper; add error raising in case of wront parameters type

* feat: add if*generation*match support for Bucket.rename_blob()

* erase resolving conflicts caused blank line

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants