Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] V4 Signature: Formatting Inconsistencies #12

Closed
frankyn opened this issue Jan 23, 2020 · 2 comments · Fixed by #56
Closed

[Storage] V4 Signature: Formatting Inconsistencies #12

frankyn opened this issue Jan 23, 2020 · 2 comments · Fixed by #56
Assignees
@tseaver
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Member

frankyn commented Jan 23, 2020

Tracking issue for work defined in companion document.

New Client Request - GCS SigV4 Formatting Inconsistencies.
@crwilcox crwilcox transferred this issue from googleapis/google-cloud-python Jan 31, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 3, 2020
@jkwlui jkwlui added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 4, 2020
@tseaver tseaver mentioned this issue Feb 12, 2020
Merged
@tseaver
Copy link
Contributor

tseaver commented Feb 12, 2020

Working through the spec today: some bits are overlapped with #9 and @IlyaFaer's PR #48.

@frankyn
Copy link
Member Author

frankyn commented Feb 12, 2020

Thanks for the update @tseaver. PLMK if there's anything I can help you with.

@tseaver tseaver mentioned this issue Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make v4 signing formatting consistent w/ spec googleapis/python-storage
4 participants
@tseaver @frankyn @jkwlui @yoshi-automation