Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

fix: migrated samples to speech 2.0.0 #78

Merged
merged 8 commits into from Oct 12, 2020
Merged

fix: migrated samples to speech 2.0.0 #78

merged 8 commits into from Oct 12, 2020

Conversation

b-loved-dreamer
Copy link
Contributor

Started updating samples

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@busunkim96
Copy link
Contributor

Hmm, it looks like some of these already exist on master. Could you rebase your branch locally?

git checkout master
git pull origin master
git checkout speechmigration
git rebase master

@leahecole
Copy link
Contributor

I'm working with him now over chat to do a rebase :)

@b-loved-dreamer
I updated the comment on the transcribe_async file to reflect time li…
a1e44e1 
…mitations on local files for the long_running_recognize
@b-loved-dreamer
I updated the comment on the transcribe_async file to reflect time li…
989704d 
…mitations on local files for the long_running_recognize
@b-loved-dreamer
docs: I updated the comment on the transcribe_async file to reflect t…
bf888d7 
…ime limitations on local files for the long_running_recognize
@b-loved-dreamer
chore: I updated the comments on the transcribe_async file to reflect…
f510e8f 
… time limitations on local files for the long_running_recognize
@b-loved-dreamer
fix: resolved conflicts
8641cf9
@zub2 zub2 mentioned this pull request Oct 5, 2020
Closed
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@telpirion telpirion requested a review from tmatsuo October 7, 2020 21:51
@b-loved-dreamer b-loved-dreamer mentioned this pull request Oct 7, 2020
Closed
tmatsuo
tmatsuo approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, maybe it's easier to review if you separate the quote changes and the migration. Maybe next time.

@b-loved-dreamer
Copy link
Contributor Author

@sirtorry, would you please review this PR.

@b-loved-dreamer b-loved-dreamer merged commit 47dd992 into googleapis:master Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@telpirion telpirion telpirion approved these changes

@sirtorry sirtorry sirtorry approved these changes

Assignees

@tmatsuo tmatsuo

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@b-loved-dreamer @busunkim96 @leahecole @tmatsuo @telpirion @sirtorry @yoshi-kokoro