Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix: Remove reference to deprecated message diarization_speaker_count #264

Merged
merged 1 commit into from Oct 4, 2021
Merged

fix: Remove reference to deprecated message diarization_speaker_count #264

merged 1 commit into from Oct 4, 2021

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Oct 4, 2021

fix: Remove reference to deprecated message "diarization_speaker_count" in favor of diarization_config

xref b/201980958

@product-auto-label product-auto-label bot added the api: speech Issues related to the googleapis/python-speech API. label Oct 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2021
@nicain nicain marked this pull request as ready for review October 4, 2021 17:56
@nicain nicain requested review from telpirion and a team as code owners October 4, 2021 17:56
@nicain nicain requested a review from loferris October 4, 2021 17:56
@nicain nicain added the samples Issues that are directly related to samples. label Oct 4, 2021
b-loved-dreamer
b-loved-dreamer approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain nicain merged commit c1f7f35 into googleapis:main Oct 4, 2021
@nicain nicain deleted the b/201980958 branch October 4, 2021 23:18
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 5, 2021
@release-please
chore: release 2.9.3 (#265)
eff590d 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.3](https://www.github.com/googleapis/python-speech/compare/v2.9.2...v2.9.3) (2021-10-04)


### Documentation

* **samples:** Remove reference to deprecated message "diarization_speaker_count" in favor of diarization_config ([#264](https://www.github.com/googleapis/python-speech/issues/264)) ([c1f7f35](https://www.github.com/googleapis/python-speech/commit/c1f7f357fe8367dafcdcb3d42e04a2619de2de62))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@nicain nicain mentioned this pull request Oct 5, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@galz10 galz10 galz10 approved these changes

@b-loved-dreamer b-loved-dreamer b-loved-dreamer approved these changes

@telpirion telpirion Awaiting requested review from telpirion

@loferris loferris Awaiting requested review from loferris loferris was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicain @busunkim96 @galz10 @b-loved-dreamer