Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

docs(samples): remove io dependency in transcribe samples #223

Merged
merged 6 commits into from Aug 10, 2021
Merged

docs(samples): remove io dependency in transcribe samples #223

merged 6 commits into from Aug 10, 2021

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Aug 9, 2021 •
edited

  • Refactor transcribe samples (transcribe_async) into two separate samples (transcribe_async_file and transcribe_async_gcs).
  • Remove dependency on io module (use open instead of io.open).
  • Fix small issue in argparse config for samples Remove CLI interface for the samples.
  • Update tests.

runner.sh:

set -e

ROOT='python-speech'

pytest ${ROOT?}/samples/snippets/transcribe_async_gcs_test.py
pytest ${ROOT?}/samples/snippets/transcribe_async_file_test.py

@snippet-bot
Copy link

snippet-bot bot commented Aug 9, 2021 •
edited

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: speech Issues related to the googleapis/python-speech API. samples Issues that are directly related to samples. labels Aug 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@nicain
refactor: Refactor transcribe samples into two separate samples (loca…
4bcd326 
…l-file vs gcs) and remove io dependency. Refactor tests.
@telpirion telpirion changed the title Remove io dependency in transcribe samples fix: remove io dependency in transcribe samples Aug 9, 2021
telpirion
telpirion approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments.

samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
@parthea parthea changed the title fix: remove io dependency in transcribe samples docs(samples): remove io dependency in transcribe samples Aug 9, 2021
@nicain nicain requested a review from telpirion August 9, 2021 21:22
telpirion
telpirion approved these changes Aug 10, 2021
View reviewed changes
samples/snippets/transcribe_async_file.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_file.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_file_test.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_file_test.py Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
@nicain nicain marked this pull request as ready for review August 10, 2021 19:01
@nicain nicain merged commit 928ca3a into googleapis:master Aug 10, 2021
@nicain nicain mentioned this pull request Aug 11, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 30, 2021
@release-please
chore: release 2.8.0 (#236)
f0f9607 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-speech/compare/v2.7.0...v2.8.0) (2021-08-19)


### Features

* Add transcript normalization ([#235](https://www.github.com/googleapis/python-speech/issues/235)) ([f76effc](https://www.github.com/googleapis/python-speech/commit/f76effc3c5477db858571d89c5b52078e85ff94e))


### Documentation

* **samples:** remove io dependency in transcribe samples ([#223](https://www.github.com/googleapis/python-speech/issues/223)) ([928ca3a](https://www.github.com/googleapis/python-speech/commit/928ca3aeb8f8665dedfa7663c56ee3bb464481cd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@telpirion telpirion telpirion approved these changes

Assignees
No one assigned
Labels
api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicain @telpirion