feat: adds model adaptation sample #121
feat: adds model adaptation sample #121
Conversation
…mitations on local files for the long_running_recognize
…ime limitations on local files for the long_running_recognize
… time limitations on local files for the long_running_recognize
pick f510e8f chore: I updated the comments on the transcribe_async file to reflect time limitations on local files for the long_running_recognize
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice the first time, but the test file name needs to either start with test_
or end with _test
for pytest to treat it as a test. It looks like it is being skipped right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are expected to setup/cleanup any resources. https://github.com/GoogleCloudPlatform/python-docs-samples/blob/89e67bcb655ed6d120dee46d2d40d866f7c72a59/storage/cloud-client/acl_test.py#L59-L65 has a good example of this.
If you need help fixing the test, please grab some time on my calendar next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making all those changes! The tests and sample LGTM. Please delete samples/snippets/speech_model_adaptation_test_beta.py
before merging.
@@ -0,0 +1,21 @@ | |||
# Copyright 2021 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File deleted.
This new sample shows how to create custom classes and phrase sets which are used for speech adaptation