Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db_api): raise exception with message for executemany() #595

Merged
merged 11 commits into from Nov 16, 2021
Merged

feat(db_api): raise exception with message for executemany() #595

merged 11 commits into from Nov 16, 2021

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Sep 28, 2021 •
edited

While working on tests for SQLAlchemy 1.4 I've noticed that using details in executemany() is not efficient - looking at them, it's hard to understand what actually gone wrong. It's better to use message property.

Relates to batch_update() method results.

@IlyaFaer IlyaFaer added api: spanner Issues related to the googleapis/python-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review September 28, 2021 08:13
@IlyaFaer IlyaFaer requested a review from a team as a code owner September 28, 2021 08:13
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2021
@IlyaFaer IlyaFaer requested a review from a team as a code owner October 25, 2021 08:15
@IlyaFaer IlyaFaer merged commit 95908f6 into googleapis:main Nov 16, 2021
@IlyaFaer IlyaFaer deleted the error_msg branch November 16, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IlyaFaer @larkee @yoshi-kokoro