Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add keepalive changes to synth.py #55

Merged
merged 2 commits into from Apr 16, 2020
Merged

fix: add keepalive changes to synth.py #55

merged 2 commits into from Apr 16, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Apr 14, 2020

Accidentally made changes to a generated file in #49 (whoops!)

This PR makes the synthtool generate the same changes.

@larkee larkee added the release blocking Required feature/issue must be fixed prior to next release. label Apr 14, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
@larkee larkee requested a review from hengfengli April 15, 2020 05:34
hengfengli
hengfengli approved these changes Apr 16, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee merged commit 805bbb7 into googleapis:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larkee @hengfengli @googlebot