Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): batch_update() results processing error #484

Merged
merged 4 commits into from Aug 15, 2021

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Aug 11, 2021

The original batch_update() method returns two values: batch status and row counts, while the sample accepts only one value from the method call (and checks its length, which is always equal to 2).

@IlyaFaer IlyaFaer added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. samples Issues that are directly related to samples. labels Aug 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 11, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review August 11, 2021 11:33
@IlyaFaer IlyaFaer requested review from a team as code owners August 11, 2021 11:33
samples/samples/snippets.py Outdated Show resolved Hide resolved
@larkee larkee merged commit bdd5f8b into googleapis:master Aug 15, 2021
@IlyaFaer IlyaFaer deleted the sample_fix branch August 15, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants