New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to support the open-telemetry status code spec change #358
fix: update to support the open-telemetry status code spec change #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this compatible with older versions of OpenTelemetry?
Also, the py3.6 unit tests are failing.
…k with in memory exporter
Don't think we should support any older versions of the library. As per the library doc the software is in Beta, and since they have changed their api, so not sure if we should support older versions?
Fixed the unit tests and system tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The emulator action is timing out while trying to resolve the dependencies. It seems to have an issue with opentelemetry-instrumentation == 0.22b0
in the constraints file. Using opentelemetry-instrumentation == 0.20b0
seems to resolve it but I don't know if this is a valid version..
Thanks for the help, that fixed the issue. Thanks 👍 |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
fix: for open-telemetry status code spec change
Fixes #357 🦕
Open telemetry has changed their specs for status code. Since the open telemetry library for python is still in beta it doesn't make much sense to use/support older version of that library.
Couple of reference: