Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for backups #35

Merged
merged 3 commits into from Mar 13, 2020
Merged

feat: add support for backups #35

merged 3 commits into from Mar 13, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Mar 13, 2020

Adds support for the new Cloud Spanner backups feature.

See backup samples for examples of common use cases.

@larkee larkee added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 13, 2020
@larkee larkee requested a review from skuruppu March 13, 2020 00:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2020
skuruppu
skuruppu reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending some quick comments through so you can answer them before you leave. I'm still reviewing.

google/cloud/spanner_v1/backup.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/database.py Outdated Show resolved Hide resolved
tests/unit/test_backup.py Outdated Show resolved Hide resolved
skuruppu
skuruppu approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like an answer to the optional backup argument for restore.

@skuruppu skuruppu changed the title feat: implement backup support feat: add backup support Mar 13, 2020
@skuruppu skuruppu changed the title feat: add backup support feat: add support for backups Mar 13, 2020
larkee and others added 2 commits March 13, 2020 15:38
@larkee larkee merged commit 39288e7 into googleapis:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larkee @skuruppu @googlebot