Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db_api): add dummy lastrowid attribute #227

Merged
merged 1 commit into from Feb 15, 2021
Merged

fix(db_api): add dummy lastrowid attribute #227

merged 1 commit into from Feb 15, 2021

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Feb 8, 2021

According to PEP 249, lastrowid should be set to None if it's impossible to set it correctly.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2021
@IlyaFaer IlyaFaer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Feb 8, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review February 8, 2021 09:12
@IlyaFaer IlyaFaer requested a review from a team as a code owner February 8, 2021 09:12
@larkee larkee merged commit 0375914 into googleapis:master Feb 15, 2021
@IlyaFaer IlyaFaer deleted the lastrowid branch February 15, 2021 15:58
@IlyaFaer IlyaFaer restored the lastrowid branch March 9, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IlyaFaer @larkee