From de4b7e7c4ecb22458f57c430c12ac468337b2c78 Mon Sep 17 00:00:00 2001 From: Connor Adams Date: Mon, 20 Jul 2020 10:53:47 -0400 Subject: [PATCH] nit fixes --- docs/opentelemetry-tracing.rst | 6 +++--- google/cloud/spanner_v1/_opentelemetry_tracing.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/opentelemetry-tracing.rst b/docs/opentelemetry-tracing.rst index f85f8c1833..4ac9f7d6c9 100644 --- a/docs/opentelemetry-tracing.rst +++ b/docs/opentelemetry-tracing.rst @@ -21,12 +21,12 @@ We also need to tell OpenTelemetry which exporter to use. For example, to export # in a seperate thread to not block on the main thread from opentelemetry.sdk.trace.export import BatchExportSpanProcessor - # create and export one trace every 1000 requests + # Create and export one trace every 1000 requests sampler = ProbabilitySampler(1/1000) - # Uses the default tracer provider + # Use the default tracer provider trace.set_tracer_provider(TracerProvider(sampler=sampler)) trace.get_tracer_provider().add_span_processor( - # initialize the cloud tracing exporter + # Initialize the cloud tracing exporter BatchExportSpanProcessor(CloudTraceSpanExporter()) ) diff --git a/google/cloud/spanner_v1/_opentelemetry_tracing.py b/google/cloud/spanner_v1/_opentelemetry_tracing.py index 93357eda98..60e68598e9 100644 --- a/google/cloud/spanner_v1/_opentelemetry_tracing.py +++ b/google/cloud/spanner_v1/_opentelemetry_tracing.py @@ -32,13 +32,13 @@ @contextmanager def trace_call(name, session, extra_attributes=None): if not HAS_OPENTELEMETRY_INSTALLED or not session: - # empty context manager. users will have to check if the generated value is None or a span + # Empty context manager. Users will have to check if the generated value is None or a span yield None return tracer = trace.get_tracer(__name__) - # base attributes that we know for every trace created + # Set base attributes that we know for every trace created attributes = { "db.type": "spanner", "db.url": spanner_client.SpannerClient.SERVICE_ADDRESS,