From af237750cb7b8bf4ad33bd1b89986396784787c9 Mon Sep 17 00:00:00 2001 From: HemangChothani <50404902+HemangChothani@users.noreply.github.com> Date: Wed, 10 Mar 2021 18:39:56 +0530 Subject: [PATCH] refactor(db_api): remove unused variables and add docs (#229) * refactor: remove unused variables and add docs * refactor: nit --- google/cloud/spanner_dbapi/connection.py | 4 ++++ google/cloud/spanner_dbapi/cursor.py | 11 ++--------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/google/cloud/spanner_dbapi/connection.py b/google/cloud/spanner_dbapi/connection.py index 6438605d3b..382882e516 100644 --- a/google/cloud/spanner_dbapi/connection.py +++ b/google/cloud/spanner_dbapi/connection.py @@ -290,6 +290,10 @@ def run_statement(self, statement, retried=False): :type statement: :class:`dict` :param statement: SQL statement to execute. + :type retried: bool + :param retried: (Optional) Retry the SQL statement if statement + execution failed. Defaults to false. + :rtype: :class:`google.cloud.spanner_v1.streamed.StreamedResultSet`, :class:`google.cloud.spanner_dbapi.checksum.ResultsChecksum` :returns: Streamed result set of the statement and a diff --git a/google/cloud/spanner_dbapi/cursor.py b/google/cloud/spanner_dbapi/cursor.py index dd097d5fc5..bcb614cf7e 100644 --- a/google/cloud/spanner_dbapi/cursor.py +++ b/google/cloud/spanner_dbapi/cursor.py @@ -138,17 +138,10 @@ def callproc(self, procname, args=None): self._raise_if_closed() def close(self): - """Prepare and execute a Spanner database operation. - - :type sql: str - :param sql: A SQL query statement. - - :type args: list - :param args: Additional parameters to supplement the SQL query. - """ + """Closes this cursor.""" self._is_closed = True - def _do_execute_update(self, transaction, sql, params, param_types=None): + def _do_execute_update(self, transaction, sql, params): sql = parse_utils.ensure_where_clause(sql) sql, params = parse_utils.sql_pyformat_args_to_spanner(sql, params)