Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django-spanner's autofield generation does not work for non-default spanner DBs #783

Open
untitaker opened this issue Aug 9, 2022 · 1 comment · May be fixed by #784
Open

django-spanner's autofield generation does not work for non-default spanner DBs #783

untitaker opened this issue Aug 9, 2022 · 1 comment · May be fixed by #784
Assignees
@asthamohta
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@untitaker
Copy link

#780 introduced a check as to whether the default database's engine is spanner or not, and depending on that decides to override id generation with clientside uuid or not.

This fix is insufficient. It does improve the situation, as django-spanner will disable its monkeypatches if the default db is not spanner.

But the original issue #742 was talking about using multiple databases, where default db is mysql. This is what django.db.connection.settings_dict refers to. The correct key to check would be django.db.connections[???].settings_dict.

Steps to reproduce

  1. set up spanner as a non-default database
  2. see that even running basic migrations against that non-default db fails, as the inserts into the django_migrations table already fail.

I'll investigate how to fix. It's likely something else has to be patched entirely.

Environment details

  • Programming language: Python
  • OS: Doesn't matter
  • Language runtime version: 3.8
  • Package version: master
@untitaker untitaker added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 9, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Aug 9, 2022
@untitaker untitaker changed the title django-spanner master broke autofield generation entirely django-spanner's autofield generation does not work for non-default spanner DBs Aug 9, 2022
untitaker added a commit to untitaker/python-spanner-django that referenced this issue Aug 9, 2022
@untitaker
Fix support for autofields in non-default databases
91c8f9f 
Fix googleapis#783

Also refactored code a bit such that version detection is no longer used
to determine whether BigAutoField exists. BigAutoField exists in Django
versions older than 3.0, and the way this is currently monkeypatched
prevents us from using any BigAutoField in Spanner with Django 2.2.
@untitaker untitaker linked a pull request Aug 9, 2022 that will close this issue
Open
untitaker added a commit to untitaker/python-spanner-django that referenced this issue Aug 9, 2022
@untitaker
fix: Support for autofields in non-default databases
e02e390 
Fix googleapis#783

Also refactored code a bit such that version detection is no longer used
to determine whether BigAutoField exists. BigAutoField exists in Django
versions older than 3.0, and the way this is currently monkeypatched
prevents us from using any BigAutoField in Spanner with Django 2.2.
@IlyaFaer
Copy link
Contributor

About the next spring a new auto incrementing primary keys features is expected to be released in Spanner. It should make autofield patch unnecessary at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asthamohta asthamohta

Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix support for autofields in non-default databases untitaker/python-spanner-django
3 participants
@untitaker @IlyaFaer @asthamohta