Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): pin sphinx to use v4 #779

Closed
wants to merge 1 commit into from
Closed

chore(deps): pin sphinx to use v4 #779

wants to merge 1 commit into from

Conversation

dandhlee
Copy link
Contributor

Fixes #768.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jul 15, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@dandhlee dandhlee marked this pull request as ready for review July 15, 2022 18:45
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2022
@IlyaFaer
Copy link
Contributor

We had a complicated situation here in Django, so I had to copy your fix to another PR (where a bunch of fixes already included):
#772

It worked find, all the tests passed. Thanks!
Closing this PR its changes are already merged.

@IlyaFaer IlyaFaer closed this Jul 18, 2022
@IlyaFaer IlyaFaer deleted the dandhlee-patch-1 branch July 18, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docfx session does not run for python-spanner-django
3 participants
@dandhlee @IlyaFaer @yoshi-kokoro