Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding documentation for GA #665

Merged
merged 12 commits into from Jun 28, 2021
Merged

Conversation

asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Jun 24, 2021

  1. Adding Quick Start, Installation, Overall design, Internals to Readme
  2. Adding API reference for:
    base-api
    compiler-api
    expressions-api
    functions-api
    introspection-api
    lookups-api
    utils-api
    creation-api
    operations-api
  3. Adding Sample code for those starting out with using Spanner with Django

@asthamohta asthamohta requested a review from vi3k6i5 June 24, 2021 09:19
@asthamohta asthamohta requested a review from a team as a code owner June 24, 2021 09:19
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jun 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
@asthamohta asthamohta changed the title Adding Documentation for GA docs: Adding documentation for GA Jun 24, 2021
django_spanner/creation.py Outdated Show resolved Hide resolved
docs/base-spi.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Jun 24, 2021

Please add a detailed description of this PR is trying to do, also link which issue it is fixing, if no issue exists for it feel free to create one.

PS: for very small and obvious PRs we can skip this step.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
docs/schema-api.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of feedback for changes.


from django.db import models

class Question(models.Model):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this has indentation issue

Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants