Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump version number after 2.2.1b1 release #652

Merged
merged 4 commits into from Jun 23, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Jun 17, 2021

Like #596, bump the version number following the 2.2.1b1 release to avoid using the same version number in development.

fixes #661

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner June 17, 2021 18:23
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jun 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2021
@larkee larkee changed the title fix: Bump version number after 2.2.1b1 release fix: bump version number after 2.2.1b1 release Jun 18, 2021
@larkee
Copy link
Contributor

larkee commented Jun 18, 2021

Shouldn't this be handled by the release bot?

@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 18, 2021

Shouldn't this be handled by the release bot?

for some reason the release bot doesn't do it. Not sure why, Also doesn't generate the Changelog properly. Chris had a guess that maybe the version numbering style is not supported by the bot.

@c24t
Copy link
Contributor

c24t commented Jun 19, 2021

Release-please doesn't understand our non-standard versioning.

@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@vi3k6i5 vi3k6i5 requested a review from c24t June 22, 2021 12:46
@vi3k6i5 vi3k6i5 merged commit 287b893 into googleapis:master Jun 23, 2021
vi3k6i5 added a commit that referenced this pull request Jun 28, 2021
* fix: Bump version number after 2.2.1b1 release

* refactor: blank change for a commit

* tests: remove failing tests from django_test_apps. Back-filling index is taking too long for these tests

* tests: add tests back to kokoro test in django_test_apps

* tests: add tests back to kokoro test in django_test_apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kokoro build is failing for new PRs with no change in code
5 participants