Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add open telemetry trace in schema and related unit tests #648

Merged
merged 15 commits into from Jun 25, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Jun 16, 2021

Add tracing in schema with related checks in unit tests.

Fixes #633 🦕

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner June 16, 2021 13:05
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@vi3k6i5 vi3k6i5 changed the title feat: Add open telemetry trace and related unit tests feat: Add open telemetry trace in schema and related unit tests Jun 16, 2021
@vi3k6i5 vi3k6i5 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 17, 2021
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not very familiar with Django usage.

For CloudSpannerDjango.alter_field, I noticed that the method is _alter_field. Should the trace reflect this? Do users call this directly?

@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 18, 2021

_alter_field

users are not going to call this method directly, this trace is added more for keeping track. Wherever calls to backend takes place then how long those calls are taking.

@vi3k6i5 vi3k6i5 requested a review from larkee June 18, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants