Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs build kokoro config for django spanner #644

Merged
merged 21 commits into from Jun 17, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Jun 15, 2021

docs: added docs build kokoro config for django spanner.

fixes #643

Docs will be published at link: https://googleapis.dev/python/django-google-spanner/latest/index.html

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner June 15, 2021 07:27
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jun 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments on .repo-metadata.json, otherwise LGTM. :)

.repo-metadata.json Outdated Show resolved Hide resolved
.repo-metadata.json Outdated Show resolved Hide resolved
@vi3k6i5 vi3k6i5 changed the title docs: added docs build kokoro config for django spanner. docs: added docs build kokoro config for django spanner Jun 15, 2021
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 16, 2021

Some small comments on .repo-metadata.json, otherwise LGTM. :)

@busunkim96 : Fixed the comments, Thanks for the help :)

@busunkim96
Copy link
Contributor

I think you'll need to copy https://github.com/googleapis/python-spanner/blob/master/.trampolinerc into this repo as well. I triggered the docs job manually and it appears to be failing on a missing bucket name: log

@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 16, 2021

I think you'll need to copy https://github.com/googleapis/python-spanner/blob/master/.trampolinerc into this repo as well. I triggered the docs job manually and it appears to be failing on a missing bucket name: log

Added the same file, thanks

Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the docs jobs is all good now! You should see them at googleapis.dev/python/django-spanner-google/latest in a bit. :) docs job log

@vi3k6i5 vi3k6i5 requested review from c24t and larkee June 16, 2021 20:11
@busunkim96
Copy link
Contributor

Docs are live! https://googleapis.dev/python/django-google-spanner/latest/index.html

FYI If you want to view the docs locally, you can run nox -s docs and open docs/_build/html in a browser.

Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the docs at the given link so this LGTM 👍

@larkee larkee changed the title docs: added docs build kokoro config for django spanner docs: add docs build kokoro config for django spanner Jun 17, 2021
@vi3k6i5 vi3k6i5 merged commit ecf241a into googleapis:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for django spanner.
3 participants