Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move migrations test modules to run against different emulator #613

Merged
merged 5 commits into from Apr 26, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Apr 25, 2021

feat: move migrations test modules to run against different emulator to distribute time taken by system test 2

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner April 25, 2021 12:24
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2021
fix: Remove un necessary file from code base (googleapis#608)
…nt emmulators to distribute time taken by emmulator 2
@vi3k6i5 vi3k6i5 changed the title feat: move migrations and queries test modules to run against different emulators to distribute time taken by emulators 2 feat: move migrations test modules to run against different emulator to distribute time taken by system test 2 Apr 26, 2021
@vi3k6i5 vi3k6i5 requested review from larkee and skuruppu April 26, 2021 05:06
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: title can be shortened to feat: move migrations test modules to run against different emulator if you add the explanation to the PR description 👍

@vi3k6i5 vi3k6i5 changed the title feat: move migrations test modules to run against different emulator to distribute time taken by system test 2 feat: move migrations test modules to run against different emulator Apr 26, 2021
@vi3k6i5 vi3k6i5 merged commit 5b3b2e4 into googleapis:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants