Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix from-scratch tutorial #573

Merged
merged 5 commits into from Jan 29, 2021
Merged

fix: fix from-scratch tutorial #573

merged 5 commits into from Jan 29, 2021

Conversation

HemangChothani
Copy link
Contributor

No description provided.

@HemangChothani HemangChothani requested a review from a team as a code owner January 7, 2021 13:03
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jan 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
c24t
c24t approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as with #574 these instructions could benefit from a rewrite.

@c24t c24t changed the title fix: fix tutorial of from-scratch app fix: fix from-scratch tutorial Jan 29, 2021
@c24t c24t merged commit 59ce5e7 into googleapis:master Jan 29, 2021
@c24t c24t deleted the django_from_scratch_tutorial branch January 29, 2021 00:26
This was referenced Apr 17, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HemangChothani @c24t