Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: erase dbapi directory and all the related tests #554

Merged
merged 12 commits into from Nov 25, 2020
Merged

refactor!: erase dbapi directory and all the related tests #554

merged 12 commits into from Nov 25, 2020

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Nov 19, 2020 •
edited

BREAKING CHANGE: all the connection API related code was moved into the original Cloud Spanner client repository. With this PR the whole dbapi directory is erased from this repository.

The dependency on google-cloud-spanner of this API is bumped to 2.0.0.

@IlyaFaer IlyaFaer added cleanup type: cleanup An internal cleanup or hygiene concern. api: spanner Issues related to the googleapis/python-spanner-django API. labels Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@IlyaFaer IlyaFaer requested a review from c24t November 19, 2020 09:27
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Nov 19, 2020 •
edited

@c24t, system tests on emulator has failed, as there are no system tests at all now. Should we disable the workflow?

c24t
c24t approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c24t, system tests on emulator has failed, as there are no system tests at all now. Should we disable the workflow?

I think so, and the deletion LGTM.

@IlyaFaer
Copy link
Contributor Author

@c24t, unit tests are not able to install google-cloud-spanner >= 2.0.0 somewhy, though I see it is released.

This was referenced Nov 24, 2020
Merged
Closed
@c24t
Copy link
Contributor

c24t commented Nov 24, 2020

@c24t, unit tests are not able to install google-cloud-spanner >= 2.0.0 somewhy, though I see it is released.

Looks like this is because they dropped support for 3.5, fix in #557.

@IlyaFaer
Copy link
Contributor Author

@c24t, as we don't actually have unit tests now, we can just comment out these nox sessions until better times.

@IlyaFaer IlyaFaer marked this pull request as ready for review November 25, 2020 09:49
@IlyaFaer IlyaFaer requested a review from a team as a code owner November 25, 2020 09:49
@c24t
Copy link
Contributor

c24t commented Nov 25, 2020

@IlyaFaer to follow up on this PR with another change that re-enables django system tests against the emulator.

@c24t c24t merged commit 8183247 into googleapis:master Nov 25, 2020
@IlyaFaer IlyaFaer deleted the erase_dbapi branch November 26, 2020 08:24
@release-please release-please bot mentioned this pull request Apr 17, 2024
Closed
This was referenced Apr 18, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. cleanup type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IlyaFaer @c24t