Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedicated unit tests for django_spanner #541

Closed
c24t opened this issue Oct 22, 2020 · 3 comments · Fixed by #611
Closed

Dedicated unit tests for django_spanner #541

c24t opened this issue Oct 22, 2020 · 3 comments · Fixed by #611
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v2.2.2b0

Comments

@c24t
Copy link
Contributor

c24t commented Oct 22, 2020

RIght now there's 0%(!) coverage for django_spanner, but django tests cover most of this dir. Do we need separate unit tests for django_spanner? This is probably a good idea, but may be redundant with existing django tests.
@c24t c24t added this to the Beta milestone Oct 22, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Oct 22, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 23, 2020
@skuruppu skuruppu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Oct 29, 2020
@c24t c24t removed this from the 11/5 Preview Release milestone Feb 4, 2021
@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Apr 6, 2021

@skuruppu : what do you think ? should we add separate unit tests?

@skuruppu
Copy link
Contributor

skuruppu commented Apr 7, 2021

Yeah that's a really good question. I feel that we shouldn't just add redundant tests if the existing tests already test the code. Is there some way we can setup either the existing coverage checker or a new tool to report the coverage for the existing tests?

@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Apr 7, 2021

okay, I will work on using coverage report from existing django unit tests.

@vi3k6i5 vi3k6i5 linked a pull request May 4, 2021 that will close this issue
feat: added unit test with coverage of 68 % #611
Merged
@c24t c24t added this to the v2.2.2b0 milestone May 14, 2021
@c24t c24t closed this as completed in #611 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v2.2.2b0
Development

Successfully merging a pull request may close this issue.

feat: added unit test with coverage of 68 % vi3k6i5/python-spanner-django
4 participants
@skuruppu @vi3k6i5 @c24t @yoshi-automation