feat: Implementing DB-API types according to the PEP-0249 specification #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
mf2199
added
api: spanner
mf2199
removed
the
kokoro:force-run
IlyaFaer
reviewed
Sep 30, 2020
google/cloud/spanner_dbapi/types.py
Outdated
| This object describes (long) binary columns in a database (e.g. LONG, RAW, BLOBS). | ||
| """ | ||
| def _time_from_ticks(ticks, tz=None): | ||
| """A helper method used to construct a DB-API time value. |
There was a problem hiding this comment.
I think we should first add system tests for these types, before merging. As they are gonna be used to convert data from user types to the Spanner types, we better check how it's working in the case close to the real.
There was a problem hiding this comment.
@IlyaFaer Reverted to the previous convention, PTAL.
mf2199
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mf2199
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mf2199
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mf2199
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes represent reworked
types.pyin accordance with the PEP-0249 Type Objects and Constructors specifications.Some of the classes implemented prior to the alpha release are not part of the DB-API standards. Those were left in for now but may be removed later in the GA release.