Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nox instead of tox for testing #459

Closed
IlyaFaer opened this issue Aug 19, 2020 · 2 comments
Closed

Use nox instead of tox for testing #459

IlyaFaer opened this issue Aug 19, 2020 · 2 comments
Assignees
@c24t
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. needs-decision type: process A process-related concern. May include testing, release, or the like.

Comments

@IlyaFaer
Copy link
Contributor

I've noticed that Django Spanner uses tox as a test base. Other Google Python packages are using nox with generated noxfiles (with lint, docs, coverage, system and unit testing sessions) - see python-spanner noxfile.py as an example. If we're going to move this API to the original Python Spanner client, we probably should use nox here to stay in touch with the original test configurations.
@IlyaFaer IlyaFaer added type: process A process-related concern. May include testing, release, or the like. api: spanner Issues related to the googleapis/python-spanner-django API. labels Aug 19, 2020
@c24t
Copy link
Contributor

c24t commented Aug 20, 2020

If using nox helps us move faster here then it may be worth it to switch, but not otherwise. Tox seems to have much better adoption outside of google-owned repos.

@c24t
Copy link
Contributor

c24t commented Sep 10, 2020

Done as of #480.

@c24t c24t closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c24t c24t

Labels
api: spanner Issues related to the googleapis/python-spanner-django API. needs-decision type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IlyaFaer @mf2199 @c24t