New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django: triage expressions_case test failures #353
Comments
Thank you for filing this issue @timgraham! Here are the audit results: operator <= for argument types: DATE, INT64
type INT64 cannot be assigned to binary, which has type BYTES
type INT64 cannot be assigned to date_field, which has type DATE
type INT64 cannot be assigned to date_time, which has type TIMESTAMP
unexpected ordering due to assuming a serial primary key
|
@timgraham I've added a skip for the 57 expression_case tests that assume a serial primary key and ordering of results in b431999, so this issue can be closed as the other 4 related have been separately filed. |
Rather than skip those tests, I believe we should instead add a commit to the Django fork to relax the assertions to ignore ordering (where possible). I would have preferred doing this all in one commit (with a proper review) like in #348. It would also be nice to make those issues more descriptive rather than just pasting a traceback without a description of what the problem is. |
Interesting. I thought that since we already had all the serial primary key skips in for a long time that we’d add them too here which is why I added the commit, but also a 3hr long wait before a confirmed case seemed like overkill.
Thanks, I’ll try more but I described the problems in the titles or was there something specifically different? Please help me out with edits as you’ve got the most Django context and know these things the most. Just the pressure from the past overdue deadline getting the most out of me as we need to ship out before March 30th, which is why for confirmed cases, I have been skipping the unproductive wait times. |
Investigate and and ticket out these issues as needed:
The text was updated successfully, but these errors were encountered: