Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: audit Django test apps #317

Closed
timgraham opened this issue Mar 10, 2020 · 0 comments · Fixed by #365
Closed

ci: audit Django test apps #317

timgraham opened this issue Mar 10, 2020 · 0 comments · Fixed by #365
Assignees
@timgraham
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.

Comments

@timgraham
Copy link
Contributor

timgraham commented Mar 10, 2020 •
edited

I'm auditing the list of Django test apps in .travis.yml. CI is running many which are unnecessary (no database interaction). Also, some folders in django/tests don't include any tests.

  • absolute_url_overrides (no database interaction)
  • admin_autodiscover (no database interaction)
  • admin_changelist
  • admin_checks (no database interaction)
  • admin_custom_urls (no database interaction)
  • admin_default_site (no database interaction)
  • admin_docs
  • admin_filters
  • admin_inlines
  • admin_ordering
  • admin_registration (no database interaction)
  • admin_scripts (no database interaction)
  • admin_utils (django-test-suite: admin_utils fails #150)
  • admin_views
  • admin_widgets (unlikely to add test coverage)
  • aggregation
  • aggregation_regress
  • annotations
  • app_loading (no database interaction)
  • apps (no database interaction)
  • auth_tests
  • backends (django: backends test failures #318)
  • base (no tests)
  • bash_completion (no database interaction)
  • basic
  • builtin_server (no database interaction)
  • bulk_create
  • cache
  • check_framework (no database interaction)
  • choices
  • conditional_processing (no database interaction)
  • constraints
  • contenttypes_tests (django: Meta.order_with_respect_to column name is incompatible with Spanner #396)
  • context_processors (no database interaction)
  • csrf_tests (no database interaction)
  • custom_columns
  • custom_lookups
  • custom_managers
  • custom_methods
  • custom_migration_operations (no tests)
  • custom_pk
  • datatypes
  • dates
  • datetimes
  • db_functions
  • dbshell (no database interaction)
  • db_typecasts (no database interaction)
  • db_utils (no database interaction)
  • decorators (no database interaction)
  • defer
  • defer_regress
  • delete
  • delete_regress
  • deprecation (no database interaction)
  • dispatch (no database interaction)
  • distinct_on_fields
  • empty
  • expressions
  • expressions_case (django: triage expressions_case test failures #353)
  • expressions_window
  • extra_regress
  • field_deconstruction (no database interaction)
  • field_defaults
  • field_subclassing (no database interaction)
  • files (no database interaction)
  • file_storage
  • file_uploads
  • filtered_relation
  • fixtures
  • fixtures_model_package
  • fixtures_regress
  • flatpages_tests
  • force_insert_update (django-test-suite: force_insert_update.tests.ForceTests.test_force_update force save doesn't work #420)
  • foreign_object (django: lookups with multiple target fields fail #421)
  • forms_tests
  • from_db_value
  • generic_inline_admin
  • generic_relations
  • generic_relations_regress
  • generic_views
  • get_earliest_or_latest
  • get_object_or_404
  • get_or_create (django-test-suite: expectations of traditional transactions fail get_or_create_tests #270)
  • gis_tests (not applicable)
  • handlers (no database interaction)
  • httpwrappers (no database interaction)
  • humanize_tests (no database interaction)
  • i18n
  • import_error_package (no tests)
  • indexes
  • inline_formsets
  • inspectdb
  • introspection
  • invalid_models_tests
  • known_related_objects
  • logging_tests (no database interaction)
  • lookup
  • m2m_and_m2o
  • m2m_intermediary
  • m2m_multiple
  • m2m_recursive
  • m2m_regress
  • m2m_signals
  • m2m_through
  • m2m_through_regress
  • m2o_recursive
  • mail (no database interaction)
  • managers_regress
  • many_to_many
  • many_to_one
  • many_to_one_null
  • max_lengths
  • messages_tests (no database interaction)
  • middleware (no database interaction)
  • middleware_exceptions (no database interaction)
  • migrate_signals
  • migrations
  • migrations2 (no tests)
  • migration_test_data_persistence
  • modeladmin
  • model_fields
  • model_forms
  • model_formsets
  • model_formsets_regress
  • model_indexes
  • model_inheritance
  • model_inheritance_regress
  • model_meta (no database interaction)
  • model_options
  • model_package
  • model_regress
  • multiple_database
  • mutually_referential
  • nested_foreign_keys
  • no_models (no database interaction)
  • null_fk
  • null_fk_ordering
  • null_queries
  • one_to_one
  • ordering
  • order_with_respect_to (django: Meta.order_with_respect_to column name is incompatible with Spanner #396)
  • or_lookups
  • pagination (all tests assume ordering by a serial pk)
  • postgres_tests (not applicable)
  • prefetch_related
  • project_template (no database interaction)
  • properties (no database interaction)
  • proxy_model_inheritance
  • proxy_models
  • queries
  • queryset_pickle
  • raw_query
  • redirects_tests
  • requests_ (no database interaction)
  • requirements (no tests)
  • reserved_names
  • resolve_url (no database interaction)
  • responses (no database interaction)
  • reverse_lookup
  • save_delete_hooks
  • schema
  • select_for_update
  • select_related
  • select_related_onetoone
  • select_related_regress
  • serializers
  • servers
  • sessions_tests (.travis.yml: test only sessions_tests #395)
  • settings_tests (no database interaction)
  • shell (no database interaction)
  • shortcuts (no database interaction)
  • signals
  • signed_cookies_tests (no database interaction)
  • signing (no database interaction)
  • sitemaps_tests
  • sites_framework
  • sites_tests
  • staticfiles_tests (no database interaction)
  • str (no database interaction)
  • string_lookup
  • swappable_models (no database interaction)
  • syndication_tests
  • template_backends (no database interaction)
  • template_loader (no database interaction)
  • templates (no tests)
  • template_tests (no database interaction)
  • test_client
  • test_client_regress
  • test_exceptions (no database interaction)
  • test_runner
  • test_runner_apps (no tests)
  • test_utils
  • timezones
  • transaction_hooks
  • transactions
  • unmanaged_models
  • update
  • update_only_fields
  • urlpatterns (no database interaction)
  • urlpatterns_reverse (no database interaction)
  • user_commands (no database interaction)
  • utils_tests (no database interaction)
  • validation
  • validators (no database interaction)
  • version (no database interaction)
  • view_tests
  • wsgi (no database interaction)
timgraham added a commit that referenced this issue Mar 10, 2020
@timgraham
ci: remove unnecessary Django test apps
4953f76 
Also, correctly catagorize some skips.

refs #317
@timgraham timgraham mentioned this issue Mar 10, 2020
Merged
timgraham added a commit that referenced this issue Mar 10, 2020
@timgraham
ci: remove unnecessary Django test apps
27d6bdc 
Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 10, 2020
@timgraham
ci: remove unnecessary Django test apps
fd57619 
Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 11, 2020
@timgraham
ci: remove unnecessary Django test apps
0b68a38 
Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 11, 2020
@timgraham
ci: remove unnecessary Django test apps and add others inadvertently …
432855a 
…removed

Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 11, 2020
@timgraham
ci: remove unnecessary Django test apps and add others inadvertently …
4e227c5 
…removed

Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 12, 2020
@timgraham
ci: remove unnecessary Django test apps and add others inadvertently …
d567c05 
…removed

Also, correctly categorize some skips.

refs #317
timgraham added a commit that referenced this issue Mar 18, 2020
@timgraham
ci: add more Django test apps
71b160e 
refs #317
odeke-em added a commit that referenced this issue Mar 18, 2020
@odeke-em
django_spanner: skip 57 expressions_case tests that assume serial pk
b431999 
Updates #317
Updates #353
timgraham added a commit that referenced this issue Mar 19, 2020
@timgraham
ci: add more Django test apps
bf477a3 
refs #317
timgraham added a commit that referenced this issue Mar 19, 2020
@timgraham
ci: add more Django test apps
859c5ff 
refs #317
@timgraham timgraham mentioned this issue Mar 19, 2020
Merged
timgraham added a commit that referenced this issue Mar 19, 2020
@timgraham
ci: add more Django test apps
ac9666d 
fixes #353, refs #317
timgraham added a commit that referenced this issue Mar 19, 2020
@timgraham
ci: add more Django test apps
08a87b1 
fixes #353, refs #317
timgraham added a commit that referenced this issue Mar 20, 2020
@timgraham
ci: add more Django test apps
945a6a7 
fixes #353, refs #317
timgraham added a commit that referenced this issue Mar 20, 2020
@timgraham
ci: add more Django test apps
7e292f4 
fixes #353, refs #317
timgraham added a commit that referenced this issue Mar 25, 2020
@timgraham
ci: add more Django test apps
8143efc 
fixes #353, refs #317
timgraham added a commit that referenced this issue Mar 25, 2020
@timgraham
ci: add more Django test apps
137aa0c 
fixes #353, refs #317
odeke-em added a commit that referenced this issue Mar 27, 2020
@odeke-em
django: skip admin_utils tests that assume serial pk
37f25f5 
Fixes #150
Upates #317
odeke-em added a commit that referenced this issue Mar 30, 2020
@odeke-em
.travis.yml: test only sessions_tests
7468d60 
Singly added sessions_tests so that we can get quick feedback.
All the other tests will be added back before squash
and final merge.

Updates #317
@odeke-em odeke-em mentioned this issue Mar 30, 2020
Merged
odeke-em added a commit that referenced this issue Mar 30, 2020
@odeke-em
.travis.yml: test sessions_tests (#395)
2bedf87 
Updates #317
timgraham added a commit that referenced this issue Apr 7, 2020
@timgraham
ci: add more Django test apps
c55b12c 
refs #317
timgraham added a commit that referenced this issue Apr 7, 2020
@timgraham
ci: add more Django test apps
2d4929f 
refs #317
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
@JustinBeckwith JustinBeckwith added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 8, 2020
timgraham added a commit that referenced this issue Apr 12, 2020
@timgraham
ci: add more Django test apps
d8b3942 
refs #317
timgraham added a commit that referenced this issue Apr 14, 2020
@timgraham
ci: add more Django test apps
128d7fd 
refs #317
timgraham added a commit that referenced this issue Apr 15, 2020
@timgraham
ci: add more Django test apps
6171914 
refs #317
timgraham added a commit that referenced this issue Apr 15, 2020
@timgraham
ci: add more Django test apps
1a365cc 
refs #317
timgraham added a commit that referenced this issue Apr 16, 2020
@timgraham
ci: add more Django test apps
878e943 
refs #317
@odeke-em odeke-em added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed triage me I really want to be triaged. labels Apr 16, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 16, 2020
timgraham added a commit that referenced this issue Apr 17, 2020
@timgraham
ci: add more Django test apps
0276a2c 
refs #317
timgraham added a commit that referenced this issue Apr 18, 2020
@timgraham
ci: add remaining Django test apps
64c4eed 
fixes #317
timgraham added a commit that referenced this issue Apr 18, 2020
@timgraham
ci: add remaining Django test apps
e34f162 
fixes #317
timgraham added a commit to timgraham/python-spanner-django that referenced this issue Apr 20, 2020
@timgraham
ci: add remaining Django test apps
97decf1 
fixes googleapis#317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timgraham timgraham

Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add remaining Django test apps googleapis/python-spanner-django
4 participants
@timgraham @JustinBeckwith @odeke-em @yoshi-automation