Skip to content

Commit

Permalink
Revert "django_spanner: skip 57 expressions_case tests that assume se…
Browse files Browse the repository at this point in the history
…rial pk"

This reverts commit b431999.

The tests have been edited to remove the serial pk assumption.

fixes #353
  • Loading branch information
timgraham committed Mar 24, 2020
1 parent 9d909f6 commit 48909f6
Showing 1 changed file with 0 additions and 57 deletions.
57 changes: 0 additions & 57 deletions django_spanner/features.py
Expand Up @@ -77,63 +77,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
'aggregation_regress.tests.AggregationTests.test_ticket_11293',
'defer_regress.tests.DeferRegressionTest.test_ticket_23270',
'distinct_on_fields.tests.DistinctOnTests.test_basic_distinct_on',
'expressions_case.tests.CaseDocumentationExamples.test_conditional_update_example',
'expressions_case.tests.CaseDocumentationExamples.test_simple_example',
'expressions_case.tests.CaseExpressionTests.test_annotate',
'expressions_case.tests.CaseExpressionTests.test_annotate_exclude',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_aggregation_in_condition',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_aggregation_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_aggregation_in_value',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_annotation_in_condition',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_annotation_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_annotation_in_value',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_expression_as_condition',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_expression_as_value',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_in_clause',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_join_in_condition',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_join_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_annotate_with_join_in_value',
'expressions_case.tests.CaseExpressionTests.test_annotate_without_default',
'expressions_case.tests.CaseExpressionTests.test_combined_expression',
'expressions_case.tests.CaseExpressionTests.test_combined_q_object',
'expressions_case.tests.CaseExpressionTests.test_filter',
'expressions_case.tests.CaseExpressionTests.test_filter_with_aggregation_in_condition',
'expressions_case.tests.CaseExpressionTests.test_filter_with_aggregation_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_filter_with_aggregation_in_value',
'expressions_case.tests.CaseExpressionTests.test_filter_with_annotation_in_condition',
'expressions_case.tests.CaseExpressionTests.test_filter_with_annotation_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_filter_with_expression_as_condition',
'expressions_case.tests.CaseExpressionTests.test_filter_with_expression_as_value',
'expressions_case.tests.CaseExpressionTests.test_filter_with_join_in_condition',
'expressions_case.tests.CaseExpressionTests.test_filter_with_join_in_predicate',
'expressions_case.tests.CaseExpressionTests.test_filter_without_default',
'expressions_case.tests.CaseExpressionTests.test_in_subquery',
'expressions_case.tests.CaseExpressionTests.test_lookup_different_fields',
'expressions_case.tests.CaseExpressionTests.test_lookup_in_condition',
'expressions_case.tests.CaseExpressionTests.test_update',
'expressions_case.tests.CaseExpressionTests.test_update_big_integer',
'expressions_case.tests.CaseExpressionTests.test_update_decimal',
'expressions_case.tests.CaseExpressionTests.test_update_duration',
'expressions_case.tests.CaseExpressionTests.test_update_email',
'expressions_case.tests.CaseExpressionTests.test_update_file',
'expressions_case.tests.CaseExpressionTests.test_update_file_path',
'expressions_case.tests.CaseExpressionTests.test_update_fk',
'expressions_case.tests.CaseExpressionTests.test_update_float',
'expressions_case.tests.CaseExpressionTests.test_update_generic_ip_address',
'expressions_case.tests.CaseExpressionTests.test_update_image',
'expressions_case.tests.CaseExpressionTests.test_update_null_boolean',
'expressions_case.tests.CaseExpressionTests.test_update_null_boolean_old',
'expressions_case.tests.CaseExpressionTests.test_update_positive_integer',
'expressions_case.tests.CaseExpressionTests.test_update_positive_small_integer',
'expressions_case.tests.CaseExpressionTests.test_update_slug',
'expressions_case.tests.CaseExpressionTests.test_update_small_integer',
'expressions_case.tests.CaseExpressionTests.test_update_text',
'expressions_case.tests.CaseExpressionTests.test_update_time',
'expressions_case.tests.CaseExpressionTests.test_update_url',
'expressions_case.tests.CaseExpressionTests.test_update_uuid',
'expressions_case.tests.CaseExpressionTests.test_update_with_expression_as_condition',
'expressions_case.tests.CaseExpressionTests.test_update_with_expression_as_value',
'expressions_case.tests.CaseExpressionTests.test_update_without_default',
'generic_relations_regress.tests.GenericRelationTests.test_annotate',
'get_earliest_or_latest.tests.TestFirstLast',
'known_related_objects.tests.ExistingRelatedInstancesTests.test_reverse_one_to_one_multi_prefetch_related',
Expand Down

2 comments on commit 48909f6

@odeke-em
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timgraham is that we'll end up doing for all the other tests that assume a primary key?

@timgraham
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I've been editing selected tests where possible and helpful.

Please sign in to comment.