Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the samples are failing, not sure why.
Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
All commits were made by Googlers with valid CLAs. |
@leahecole When you have a moment please review the samples https://github.com/googleapis/python-securitycenter/pull/49/files#diff-929314196ba76c84956d324d5c95111e Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples LGTM to me if tests are passing with the caveat that I am super unfamiliar with this product
@leahecole Thanks for the review! Could you "approve" via the GItHub UI? (it looks like I am blocked from merging b/c of the Codeowners requirement). Tests are passing: https://source.cloud.google.com/results/invocations/f262a36c-c597-4aed-bf9b-07c5c32aa3f3/targets/github%2Fpython-securitycenter%2Fsamples%2Fsnippets/tests 馃榿 |
Yup sorry about that! |
Blockedgoogleapis/proto-plus-python#81 is resolved. Stringy enums are now convertible, allowing the library to turn proto in JSON back into library types. 馃コ