Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat: add support for v1 #15

Merged
merged 2 commits into from Mar 6, 2020
Merged

feat: add support for v1 #15

merged 2 commits into from Mar 6, 2020

Conversation

busunkim96
Copy link
Contributor

Primarily adds support for v1 API.

Also includes some template updates.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@busunkim96 busunkim96 self-assigned this Feb 26, 2020
@busunkim96
Copy link
Contributor Author

index.rst needs a small fix:



Traceback (most recent call last):
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app.build(args.force_all, filenames)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/application.py", line 349, in build
    self.builder.build_update()
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 299, in build_update
    len(to_build))
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 311, in build
    updated_docnames = set(self.read())
  File "/usr/local/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 219, in pending_warnings
    memhandler.flushTo(logger)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 184, in flushTo
    logger.handle(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 1524, in handle
    self.callHandlers(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 1586, in callHandlers
    hdlr.handle(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 890, in handle
    rv = self.filter(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 751, in filter
    result = f.filter(record)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 404, in filter
    raise SphinxWarning(location + ":" + message)
sphinx.errors.SphinxWarning: /tmpfs/src/github/python-secret-manager/docs/index.rst:4:Title underline too short.

v1 Api Reference
-------------

Warning, treated as error:
/tmpfs/src/github/python-secret-manager/docs/index.rst:4:Title underline too short.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2020
@gcf-merge-on-green
Copy link

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@busunkim96 busunkim96 merged commit cc97391 into master Mar 6, 2020
@busunkim96 busunkim96 deleted the v1 branch March 11, 2022 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants