Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

docs(secretmanager): add sample code for receiving a Pub/Sub message #138

Merged
merged 6 commits into from Jul 28, 2021

Conversation

sigilite
Copy link
Contributor

@sigilite sigilite commented Jun 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Release-As: 2.7.0

@sigilite sigilite requested a review from a team as a code owner June 22, 2021 15:15
@sigilite sigilite requested review from dinagraves and removed request for a team June 22, 2021 15:15
@google-cla
Copy link

google-cla bot commented Jun 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the googleapis/python-secret-manager API. label Jun 22, 2021
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 22, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 22, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 22, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 22, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 22, 2021
@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 23, 2021
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 23, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sigilite sigilite changed the title add sample code for receiving a Pub/Sub notification from Secret Manager feat(secretmanager): add sample code for receiving a Pub/Sub message from Secret Manager Jun 23, 2021
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2021
Co-authored-by: Dina Graves Portman <dinagraves@google.com>
@google-cla
Copy link

google-cla bot commented Jul 2, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jul 2, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@parthea parthea changed the title feat(secretmanager): add sample code for receiving a Pub/Sub message from Secret Manager docs(secretmanager): add sample code for receiving a Pub/Sub message from Secret Manager Jul 12, 2021
@google-cla
Copy link

google-cla bot commented Jul 28, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 28, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 28, 2021
@google-cla
Copy link

google-cla bot commented Jul 28, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jul 28, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 28, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 28, 2021
@parthea parthea changed the title docs(secretmanager): add sample code for receiving a Pub/Sub message from Secret Manager docs(secretmanager): add sample code for receiving a Pub/Sub message Jul 28, 2021
@parthea parthea merged commit 51f743d into googleapis:master Jul 28, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 3, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.7.0](https://www.github.com/googleapis/python-secret-manager/compare/v2.6.0...v2.7.0) (2021-08-03)


### Features

* add filter to customize the output of ListSecrets/ListSecretVersions calls ([#161](https://www.github.com/googleapis/python-secret-manager/issues/161)) ([c09615c](https://www.github.com/googleapis/python-secret-manager/commit/c09615c328782f0a15201cb4f2c7387b0a6ce51d))


### Bug Fixes

* **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#153](https://www.github.com/googleapis/python-secret-manager/issues/153)) ([1e8a4aa](https://www.github.com/googleapis/python-secret-manager/commit/1e8a4aae06badda947717217c224366963664bdc))
* enable self signed jwt for grpc ([#158](https://www.github.com/googleapis/python-secret-manager/issues/158)) ([9ebe2b3](https://www.github.com/googleapis/python-secret-manager/commit/9ebe2b3a683de1d710ec3e91b444eb71b2ef0f6b))


### Documentation

* **secretmanager:** add sample code for receiving a Pub/Sub message ([#138](https://www.github.com/googleapis/python-secret-manager/issues/138)) ([51f743d](https://www.github.com/googleapis/python-secret-manager/commit/51f743dfe2de41ef0378fff08c92c506dd11fc2b))


### Miscellaneous Chores

* release as 2.6.1 ([#159](https://www.github.com/googleapis/python-secret-manager/issues/159)) ([b686310](https://www.github.com/googleapis/python-secret-manager/commit/b686310643ec5fbd090a5d58d8a7694bdc6eebb9))
* release as 2.7.0 ([#163](https://www.github.com/googleapis/python-secret-manager/issues/163)) ([b1c148b](https://www.github.com/googleapis/python-secret-manager/commit/b1c148bba25374bd9a62a6b823bf10ffd6215e9e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: secretmanager Issues related to the googleapis/python-secret-manager API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants