feat: add filter to customize the output of ListSecrets/ListSecretVer…

…sions calls (#161) PiperOrigin-RevId: 387156636 Source-Link: googleapis/googleapis@2948f31 Source-Link: googleapis/googleapis-gen@1e23916
googleapis · Jul 28, 2021 · c09615c · c09615c
1 parent b686310
commit c09615c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/google/cloud/secretmanager_v1/types/service.py b/google/cloud/secretmanager_v1/types/service.py
@@ -59,11 +59,18 @@ class ListSecretsRequest(proto.Message):
         page_token (str):
             Optional. Pagination token, returned earlier via
             [ListSecretsResponse.next_page_token][google.cloud.secretmanager.v1.ListSecretsResponse.next_page_token].
+        filter (str):
+            Optional. Filter string, adhering to the rules in
+            `List-operation
+            filtering <https://cloud.google.com/secret-manager/docs/filtering>`__.
+            List only secrets matching the filter. If filter is empty,
+            all secrets are listed.
     """
 
     parent = proto.Field(proto.STRING, number=1,)
     page_size = proto.Field(proto.INT32, number=2,)
     page_token = proto.Field(proto.STRING, number=3,)
+    filter = proto.Field(proto.STRING, number=4,)
 
 
 class ListSecretsResponse(proto.Message):
@@ -173,11 +180,18 @@ class ListSecretVersionsRequest(proto.Message):
         page_token (str):
             Optional. Pagination token, returned earlier via
             ListSecretVersionsResponse.next_page_token][].
+        filter (str):
+            Optional. Filter string, adhering to the rules in
+            `List-operation
+            filtering <https://cloud.google.com/secret-manager/docs/filtering>`__.
+            List only secret versions matching the filter. If filter is
+            empty, all secret versions are listed.
     """
 
     parent = proto.Field(proto.STRING, number=1,)
     page_size = proto.Field(proto.INT32, number=2,)
     page_token = proto.Field(proto.STRING, number=3,)
+    filter = proto.Field(proto.STRING, number=4,)
 
 
 class ListSecretVersionsResponse(proto.Message):

diff --git a/scripts/fixup_secretmanager_v1_keywords.py b/scripts/fixup_secretmanager_v1_keywords.py
@@ -49,8 +49,8 @@ class secretmanagerCallTransformer(cst.CSTTransformer):
           'get_iam_policy': ('resource', 'options', ),
           'get_secret': ('name', ),
           'get_secret_version': ('name', ),
-          'list_secrets': ('parent', 'page_size', 'page_token', ),
-          'list_secret_versions': ('parent', 'page_size', 'page_token', ),
+          'list_secrets': ('parent', 'page_size', 'page_token', 'filter', ),
+          'list_secret_versions': ('parent', 'page_size', 'page_token', 'filter', ),
           'set_iam_policy': ('resource', 'policy', ),
           'test_iam_permissions': ('resource', 'permissions', ),
           'update_secret': ('secret', 'update_mask', ),