From 494f3f638203fd683e36bdf882d8a29b9b303dc5 Mon Sep 17 00:00:00 2001
From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date: Fri, 9 Jul 2021 20:54:10 +0000
Subject: [PATCH] feat: Tune Secret Manager auto retry parameters (#144)

UNKNOWN removed from retryable errors per AIP-194. Added RESOURCE_EXHAUSTED with adjusted parameters for better performance with spikes of AccessSecretVersion requests at or near quota limits.

PiperOrigin-RevId: 383886699

Source-Link: https://github.com/googleapis/googleapis/commit/1eade8161f2ef102282869bc3eb18841807b2b46

Source-Link: https://github.com/googleapis/googleapis-gen/commit/090b0f7df47c003b8aa2871830f480f4543c2ee4
---
 .../services/secret_manager_service/async_client.py        | 7 ++++---
 .../services/secret_manager_service/transports/base.py     | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/google/cloud/secretmanager_v1/services/secret_manager_service/async_client.py b/google/cloud/secretmanager_v1/services/secret_manager_service/async_client.py
index eec4552..74fa670 100644
--- a/google/cloud/secretmanager_v1/services/secret_manager_service/async_client.py
+++ b/google/cloud/secretmanager_v1/services/secret_manager_service/async_client.py
@@ -919,11 +919,12 @@ async def access_secret_version(
         rpc = gapic_v1.method_async.wrap_method(
             self._client._transport.access_secret_version,
             default_retry=retries.Retry(
-                initial=1.0,
+                initial=2.0,
                 maximum=60.0,
-                multiplier=1.3,
+                multiplier=2.0,
                 predicate=retries.if_exception_type(
-                    core_exceptions.ServiceUnavailable, core_exceptions.Unknown,
+                    core_exceptions.ResourceExhausted,
+                    core_exceptions.ServiceUnavailable,
                 ),
                 deadline=60.0,
             ),
diff --git a/google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py b/google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py
index e476ec5..ec19bfd 100644
--- a/google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py
+++ b/google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py
@@ -187,11 +187,12 @@ def _prep_wrapped_messages(self, client_info):
             self.access_secret_version: gapic_v1.method.wrap_method(
                 self.access_secret_version,
                 default_retry=retries.Retry(
-                    initial=1.0,
+                    initial=2.0,
                     maximum=60.0,
-                    multiplier=1.3,
+                    multiplier=2.0,
                     predicate=retries.if_exception_type(
-                        core_exceptions.ServiceUnavailable, core_exceptions.Unknown,
+                        core_exceptions.ResourceExhausted,
+                        core_exceptions.ServiceUnavailable,
                     ),
                     deadline=60.0,
                 ),