New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support variable create / update methods and text attribute #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor nit.
@software-dov sorry for the extra round, I did not consider the linting step in the presubmit, can you re-run kokoro? As an aside, it might be worth documenting the steps one can use to replicate the presubmit in the CONTRIBUTING doc, to simplify contributions and waste less time for reviewers. I can do that after if you think it useful. |
This PR adds support for variable
create
andupdate
methods.The
create
method has been implemented in theVariable
class instead ofConfig
(which would have given symmetry withget_variable
) for a couple of reasons:config.variable()
, setting the desired attribute, then saving_set_properties
like other variable methodsThis also adds support for the
text
attribute, which can now be used in alternative to the previously supportedvalue
. Thecreate
andupdate
methods enforce mutual exclusivity of the two attributes.Fixes #1