Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove six #105

Merged
merged 1 commit into from Sep 20, 2021
Merged

fix: remove six #105

merged 1 commit into from Sep 20, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Sep 20, 2021 •
edited

Six was used in the tests for Python 2 compatibility and is no longer needed.

Fixes #90, #91, #92, #93, #94, #95, #96, #97, #98 馃

@busunkim96 busunkim96 requested a review from a team as a code owner September 20, 2021 21:22
@product-auto-label product-auto-label bot added the api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. label Sep 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@busunkim96 busunkim96 merged commit 152b9c6 into main Sep 20, 2021
@busunkim96 busunkim96 deleted the remove-six branch September 20, 2021 21:30
This was referenced Sep 20, 2021
Closed
Closed
Closed
Closed
Closed
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 20, 2021
@release-please
chore: release 0.32.5 (#106)
59588c0 
馃 I have created a release \*beep\* \*boop\*
---
### [0.32.5](https://www.github.com/googleapis/python-runtimeconfig/compare/v0.32.4...v0.32.5) (2021-09-20)


### Bug Fixes

* remove six ([#105](https://www.github.com/googleapis/python-runtimeconfig/issues/105)) ([152b9c6](https://www.github.com/googleapis/python-runtimeconfig/commit/152b9c6316c2dcc482106997b6ee6944ee6d0245))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests.unit.test__http.TestConnection: test_build_api_url_no_extra_query_params failed
2 participants
@busunkim96 @tseaver