From 6ac929347a2471658f52dbd2dd3ab06cc69e84b7 Mon Sep 17 00:00:00 2001 From: yoshi-automation Date: Thu, 17 Dec 2020 06:09:46 -0800 Subject: [PATCH] feat: Add support for "billingAccounts" as another parent resource name for recommendations and insights APIs. PiperOrigin-RevId: 347984439 Source-Author: Google APIs Source-Date: Thu Dec 17 02:15:37 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: be40b52d80a2131a1b48f4720c4e8024167faad1 Source-Link: https://github.com/googleapis/googleapis/commit/be40b52d80a2131a1b48f4720c4e8024167faad1 --- .../recommender_v1/services/recommender/async_client.py | 6 +----- .../cloud/recommender_v1/services/recommender/client.py | 6 +----- google/cloud/recommender_v1/types/recommendation.py | 8 ++++---- google/cloud/recommender_v1/types/recommender_service.py | 8 ++------ synth.metadata | 6 +++--- 5 files changed, 11 insertions(+), 23 deletions(-) diff --git a/google/cloud/recommender_v1/services/recommender/async_client.py b/google/cloud/recommender_v1/services/recommender/async_client.py index 2302ff9..bdb77f5 100644 --- a/google/cloud/recommender_v1/services/recommender/async_client.py +++ b/google/cloud/recommender_v1/services/recommender/async_client.py @@ -181,8 +181,6 @@ async def list_insights( LOCATION here refers to GCP Locations: https://cloud.google.com/about/locations/ - INSIGHT_TYPE_ID refers to supported insight types: - https://cloud.google.com/recommender/docs/insights/insight-types.) This corresponds to the ``parent`` field on the ``request`` instance; if ``request`` is provided, this should not be set. @@ -461,9 +459,7 @@ async def list_recommendations( "projects/[PROJECT_NUMBER]/locations/[LOCATION]/recommenders/[RECOMMENDER_ID]", LOCATION here refers to GCP Locations: - https://cloud.google.com/about/locations/ RECOMMENDER_ID - refers to supported recommenders: - https://cloud.google.com/recommender/docs/recommenders. + https://cloud.google.com/about/locations/ This corresponds to the ``parent`` field on the ``request`` instance; if ``request`` is provided, this should not be set. diff --git a/google/cloud/recommender_v1/services/recommender/client.py b/google/cloud/recommender_v1/services/recommender/client.py index 7139bd5..fb75aa8 100644 --- a/google/cloud/recommender_v1/services/recommender/client.py +++ b/google/cloud/recommender_v1/services/recommender/client.py @@ -424,8 +424,6 @@ def list_insights( LOCATION here refers to GCP Locations: https://cloud.google.com/about/locations/ - INSIGHT_TYPE_ID refers to supported insight types: - https://cloud.google.com/recommender/docs/insights/insight-types.) This corresponds to the ``parent`` field on the ``request`` instance; if ``request`` is provided, this should not be set. @@ -691,9 +689,7 @@ def list_recommendations( "projects/[PROJECT_NUMBER]/locations/[LOCATION]/recommenders/[RECOMMENDER_ID]", LOCATION here refers to GCP Locations: - https://cloud.google.com/about/locations/ RECOMMENDER_ID - refers to supported recommenders: - https://cloud.google.com/recommender/docs/recommenders. + https://cloud.google.com/about/locations/ This corresponds to the ``parent`` field on the ``request`` instance; if ``request`` is provided, this should not be set. diff --git a/google/cloud/recommender_v1/types/recommendation.py b/google/cloud/recommender_v1/types/recommendation.py index e1c4de9..7becf01 100644 --- a/google/cloud/recommender_v1/types/recommendation.py +++ b/google/cloud/recommender_v1/types/recommendation.py @@ -217,11 +217,11 @@ class Operation(proto.Message): - Example: ``{ "/versions/*/name" : "it-123" "/versions/*/targetSize/percent": 20 }`` - - Example: ``{ "/bindings/*/role": "roles/owner" + - Example: ``{ "/bindings/*/role": "roles/admin" "/bindings/*/condition" : null }`` - - Example: ``{ "/bindings/*/role": "roles/owner" - "/bindings/*/members/*" : ["x@example.com", - "y@example.com"] }`` When both path_filters and + - Example: ``{ "/bindings/*/role": "roles/admin" + "/bindings/*/members/*" : ["x@google.com", + "y@google.com"] }`` When both path_filters and path_value_matchers are set, an implicit AND must be performed. path_value_matchers (Sequence[~.recommendation.Operation.PathValueMatchersEntry]): diff --git a/google/cloud/recommender_v1/types/recommender_service.py b/google/cloud/recommender_v1/types/recommender_service.py index c366b02..eaf488e 100644 --- a/google/cloud/recommender_v1/types/recommender_service.py +++ b/google/cloud/recommender_v1/types/recommender_service.py @@ -52,9 +52,7 @@ class ListInsightsRequest(proto.Message): "projects/[PROJECT_NUMBER]/locations/[LOCATION]/insightTypes/[INSIGHT_TYPE_ID]", LOCATION here refers to GCP Locations: - https://cloud.google.com/about/locations/ INSIGHT_TYPE_ID - refers to supported insight types: - https://cloud.google.com/recommender/docs/insights/insight-types.) + https://cloud.google.com/about/locations/ page_size (int): Optional. The maximum number of results to return from this request. Non-positive values @@ -147,9 +145,7 @@ class ListRecommendationsRequest(proto.Message): "projects/[PROJECT_NUMBER]/locations/[LOCATION]/recommenders/[RECOMMENDER_ID]", LOCATION here refers to GCP Locations: - https://cloud.google.com/about/locations/ RECOMMENDER_ID - refers to supported recommenders: - https://cloud.google.com/recommender/docs/recommenders. + https://cloud.google.com/about/locations/ page_size (int): Optional. The maximum number of results to return from this request. Non-positive values diff --git a/synth.metadata b/synth.metadata index 8cc4749..0ca8755 100644 --- a/synth.metadata +++ b/synth.metadata @@ -4,15 +4,15 @@ "git": { "name": ".", "remote": "https://github.com/googleapis/python-recommender.git", - "sha": "10043cc32d9c13ab92da62e214a972918336e88d" + "sha": "545e479350b6722414f8987b752c2e5fbc3357f5" } }, { "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "5256ab60f3d396a3d1bd393043776936b9651c5b", - "internalRef": "347703845" + "sha": "be40b52d80a2131a1b48f4720c4e8024167faad1", + "internalRef": "347984439" } }, {