From 10043cc32d9c13ab92da62e214a972918336e88d Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Tue, 15 Dec 2020 12:28:34 -0800 Subject: [PATCH] fix: remove client side gRPC receive limit (#56) * changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * fix: remove client recv msg limit fix: add enums to `types/__init__.py` PiperOrigin-RevId: 347055288 Source-Author: Google APIs Source-Date: Fri Dec 11 12:44:37 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: dd372aa22ded7a8ba6f0e03a80e06358a3fa0907 Source-Link: https://github.com/googleapis/googleapis/commit/dd372aa22ded7a8ba6f0e03a80e06358a3fa0907 --- .../services/recommender/transports/__init__.py | 1 - .../services/recommender/transports/grpc.py | 10 +++++++++- .../services/recommender/transports/grpc_asyncio.py | 8 ++++++++ google/cloud/recommender_v1/types/__init__.py | 1 - .../services/recommender/transports/__init__.py | 1 - .../services/recommender/transports/grpc.py | 10 +++++++++- .../services/recommender/transports/grpc_asyncio.py | 8 ++++++++ google/cloud/recommender_v1beta1/types/__init__.py | 1 - synth.metadata | 4 ++-- tests/unit/gapic/recommender_v1/test_recommender.py | 8 ++++++++ .../unit/gapic/recommender_v1beta1/test_recommender.py | 8 ++++++++ 11 files changed, 52 insertions(+), 8 deletions(-) diff --git a/google/cloud/recommender_v1/services/recommender/transports/__init__.py b/google/cloud/recommender_v1/services/recommender/transports/__init__.py index d099ae4..1ad4570 100644 --- a/google/cloud/recommender_v1/services/recommender/transports/__init__.py +++ b/google/cloud/recommender_v1/services/recommender/transports/__init__.py @@ -28,7 +28,6 @@ _transport_registry["grpc"] = RecommenderGrpcTransport _transport_registry["grpc_asyncio"] = RecommenderGrpcAsyncIOTransport - __all__ = ( "RecommenderTransport", "RecommenderGrpcTransport", diff --git a/google/cloud/recommender_v1/services/recommender/transports/grpc.py b/google/cloud/recommender_v1/services/recommender/transports/grpc.py index 90c97a5..1f1bd87 100644 --- a/google/cloud/recommender_v1/services/recommender/transports/grpc.py +++ b/google/cloud/recommender_v1/services/recommender/transports/grpc.py @@ -152,6 +152,10 @@ def __init__( ssl_credentials=ssl_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._ssl_channel_credentials = ssl_credentials else: @@ -170,6 +174,10 @@ def __init__( ssl_credentials=ssl_channel_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._stubs = {} # type: Dict[str, Callable] @@ -196,7 +204,7 @@ def create_channel( ) -> grpc.Channel: """Create and return a gRPC channel object. Args: - address (Optionsl[str]): The host for the channel to use. + address (Optional[str]): The host for the channel to use. credentials (Optional[~.Credentials]): The authorization credentials to attach to requests. These credentials identify this application to the service. If diff --git a/google/cloud/recommender_v1/services/recommender/transports/grpc_asyncio.py b/google/cloud/recommender_v1/services/recommender/transports/grpc_asyncio.py index 7f2fbff..4098244 100644 --- a/google/cloud/recommender_v1/services/recommender/transports/grpc_asyncio.py +++ b/google/cloud/recommender_v1/services/recommender/transports/grpc_asyncio.py @@ -197,6 +197,10 @@ def __init__( ssl_credentials=ssl_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._ssl_channel_credentials = ssl_credentials else: @@ -215,6 +219,10 @@ def __init__( ssl_credentials=ssl_channel_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) # Run the base constructor. diff --git a/google/cloud/recommender_v1/types/__init__.py b/google/cloud/recommender_v1/types/__init__.py index 04032ec..f75c4f2 100644 --- a/google/cloud/recommender_v1/types/__init__.py +++ b/google/cloud/recommender_v1/types/__init__.py @@ -42,7 +42,6 @@ MarkRecommendationFailedRequest, ) - __all__ = ( "Insight", "InsightStateInfo", diff --git a/google/cloud/recommender_v1beta1/services/recommender/transports/__init__.py b/google/cloud/recommender_v1beta1/services/recommender/transports/__init__.py index d099ae4..1ad4570 100644 --- a/google/cloud/recommender_v1beta1/services/recommender/transports/__init__.py +++ b/google/cloud/recommender_v1beta1/services/recommender/transports/__init__.py @@ -28,7 +28,6 @@ _transport_registry["grpc"] = RecommenderGrpcTransport _transport_registry["grpc_asyncio"] = RecommenderGrpcAsyncIOTransport - __all__ = ( "RecommenderTransport", "RecommenderGrpcTransport", diff --git a/google/cloud/recommender_v1beta1/services/recommender/transports/grpc.py b/google/cloud/recommender_v1beta1/services/recommender/transports/grpc.py index a7a11e5..10c3583 100644 --- a/google/cloud/recommender_v1beta1/services/recommender/transports/grpc.py +++ b/google/cloud/recommender_v1beta1/services/recommender/transports/grpc.py @@ -152,6 +152,10 @@ def __init__( ssl_credentials=ssl_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._ssl_channel_credentials = ssl_credentials else: @@ -170,6 +174,10 @@ def __init__( ssl_credentials=ssl_channel_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._stubs = {} # type: Dict[str, Callable] @@ -196,7 +204,7 @@ def create_channel( ) -> grpc.Channel: """Create and return a gRPC channel object. Args: - address (Optionsl[str]): The host for the channel to use. + address (Optional[str]): The host for the channel to use. credentials (Optional[~.Credentials]): The authorization credentials to attach to requests. These credentials identify this application to the service. If diff --git a/google/cloud/recommender_v1beta1/services/recommender/transports/grpc_asyncio.py b/google/cloud/recommender_v1beta1/services/recommender/transports/grpc_asyncio.py index 8ff572b..3f4fb2b 100644 --- a/google/cloud/recommender_v1beta1/services/recommender/transports/grpc_asyncio.py +++ b/google/cloud/recommender_v1beta1/services/recommender/transports/grpc_asyncio.py @@ -197,6 +197,10 @@ def __init__( ssl_credentials=ssl_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) self._ssl_channel_credentials = ssl_credentials else: @@ -215,6 +219,10 @@ def __init__( ssl_credentials=ssl_channel_credentials, scopes=scopes or self.AUTH_SCOPES, quota_project_id=quota_project_id, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) # Run the base constructor. diff --git a/google/cloud/recommender_v1beta1/types/__init__.py b/google/cloud/recommender_v1beta1/types/__init__.py index 04032ec..f75c4f2 100644 --- a/google/cloud/recommender_v1beta1/types/__init__.py +++ b/google/cloud/recommender_v1beta1/types/__init__.py @@ -42,7 +42,6 @@ MarkRecommendationFailedRequest, ) - __all__ = ( "Insight", "InsightStateInfo", diff --git a/synth.metadata b/synth.metadata index 321a7dd..9b5960f 100644 --- a/synth.metadata +++ b/synth.metadata @@ -11,8 +11,8 @@ "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "7ea91db77f53f169a08726bd33efb73042c38284", - "internalRef": "343321102" + "sha": "dd372aa22ded7a8ba6f0e03a80e06358a3fa0907", + "internalRef": "347055288" } }, { diff --git a/tests/unit/gapic/recommender_v1/test_recommender.py b/tests/unit/gapic/recommender_v1/test_recommender.py index 1ee5b68..1ffd245 100644 --- a/tests/unit/gapic/recommender_v1/test_recommender.py +++ b/tests/unit/gapic/recommender_v1/test_recommender.py @@ -2842,6 +2842,10 @@ def test_recommender_transport_channel_mtls_with_client_cert_source(transport_cl scopes=("https://www.googleapis.com/auth/cloud-platform",), ssl_credentials=mock_ssl_cred, quota_project_id=None, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) assert transport.grpc_channel == mock_grpc_channel assert transport._ssl_channel_credentials == mock_ssl_cred @@ -2880,6 +2884,10 @@ def test_recommender_transport_channel_mtls_with_adc(transport_class): scopes=("https://www.googleapis.com/auth/cloud-platform",), ssl_credentials=mock_ssl_cred, quota_project_id=None, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) assert transport.grpc_channel == mock_grpc_channel diff --git a/tests/unit/gapic/recommender_v1beta1/test_recommender.py b/tests/unit/gapic/recommender_v1beta1/test_recommender.py index 2844736..3ea1c2c 100644 --- a/tests/unit/gapic/recommender_v1beta1/test_recommender.py +++ b/tests/unit/gapic/recommender_v1beta1/test_recommender.py @@ -2842,6 +2842,10 @@ def test_recommender_transport_channel_mtls_with_client_cert_source(transport_cl scopes=("https://www.googleapis.com/auth/cloud-platform",), ssl_credentials=mock_ssl_cred, quota_project_id=None, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) assert transport.grpc_channel == mock_grpc_channel assert transport._ssl_channel_credentials == mock_ssl_cred @@ -2880,6 +2884,10 @@ def test_recommender_transport_channel_mtls_with_adc(transport_class): scopes=("https://www.googleapis.com/auth/cloud-platform",), ssl_credentials=mock_ssl_cred, quota_project_id=None, + options=[ + ("grpc.max_send_message_length", -1), + ("grpc.max_receive_message_length", -1), + ], ) assert transport.grpc_channel == mock_grpc_channel