Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

docs(samples): added recaptcha code samples and tests #112

Merged
merged 27 commits into from Oct 13, 2021
Merged

docs(samples): added recaptcha code samples and tests #112

merged 27 commits into from Oct 13, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Aug 27, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #111 🦕

@Sita04 Sita04 added api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. samples Issues that are directly related to samples. labels Aug 27, 2021
@Sita04 Sita04 requested a review from a team as a code owner August 27, 2021 19:29
@Sita04 Sita04 requested a review from kurtisvg August 27, 2021 19:29
@snippet-bot
Copy link

snippet-bot bot commented Aug 27, 2021 •
edited

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2021
@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2021
kurtisvg
kurtisvg suggested changes Aug 27, 2021
View reviewed changes
Copy link

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I activated the API on the project, but looks like you are still having some test failures.

samples/snippets/app.py Outdated Show resolved Hide resolved
samples/snippets/site_key.py Outdated Show resolved Hide resolved
samples/snippets/site_key.py Outdated Show resolved Hide resolved
samples/snippets/test_create_assessment.py Outdated Show resolved Hide resolved
samples/snippets/test_create_assessment.py Outdated Show resolved Hide resolved
samples/snippets/test_create_assessment.py Outdated Show resolved Hide resolved
samples/snippets/test_site_key.py Outdated Show resolved Hide resolved
@kurtisvg kurtisvg added the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 27, 2021
@Sita04 Sita04 marked this pull request as draft August 27, 2021 21:17
@FrodoTheTrue FrodoTheTrue added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@Sita04 Sita04 marked this pull request as ready for review September 8, 2021 11:16
@Sita04 Sita04 added blunderbuss: assign Instruct blunderbuss to assign someone and removed blunderbuss: assign Instruct blunderbuss to assign someone labels Sep 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@busunkim96 busunkim96 mentioned this pull request Sep 30, 2021
Closed
@Sita04 Sita04 requested a review from a team as a code owner October 5, 2021 23:04
busunkim96
busunkim96 reviewed Oct 5, 2021
View reviewed changes
.kokoro/docker/samples/Dockerfile Outdated
# https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.kokoro/docker/Dockerfile
FROM gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker

# TODO: Add Chrome Installation Here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sita04 I've updated your branch with the config changes necessary to use this Dockerfile. Please fill this with whatever additional packages you need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Bu Sun!

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@parthea
Copy link
Contributor

parthea commented Oct 12, 2021 •
edited

I've updated permissions and tests are passing now! I've added the owlbot:run label to force owlbot to run which will update the noxfile to add python 3.10 testing for samples.

kurtisvg
kurtisvg approved these changes Oct 12, 2021
View reviewed changes
samples/snippets/create_assessment.py Show resolved Hide resolved
samples/snippets/create_assessment.py Outdated Show resolved Hide resolved
@Sita04 Sita04 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@parthea parthea merged commit 879acf1 into googleapis:main Oct 13, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 21, 2021
@release-please
chore: release 1.3.0 (#138)
3ba3674 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.3.0](https://www.github.com/googleapis/python-recaptcha-enterprise/compare/v1.2.0...v1.3.0) (2021-10-14)


### Features

* add support for python 3.10 ([#137](https://www.github.com/googleapis/python-recaptcha-enterprise/issues/137)) ([fda16a4](https://www.github.com/googleapis/python-recaptcha-enterprise/commit/fda16a44a84b173a8866090021e03eef0cb82025))


### Documentation

* **samples:** add reCAPTCHA Enterprise code samples  ([#112](https://www.github.com/googleapis/python-recaptcha-enterprise/issues/112)) ([879acf1](https://www.github.com/googleapis/python-recaptcha-enterprise/commit/879acf12d24b5148e372f0f76a243ea0fc66286e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

@Sita04 Sita04

Labels
api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. blunderbuss: assign Instruct blunderbuss to assign someone cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide code samples for recaptcha enterprise
6 participants
@Sita04 @parthea @busunkim96 @kurtisvg @FrodoTheTrue @yoshi-kokoro