Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure tasks are always awaited to remove shutdown errors #57

Merged
merged 2 commits into from Nov 5, 2020
Merged

fix: Ensure tasks are always awaited to remove shutdown errors #57

merged 2 commits into from Nov 5, 2020

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested a review from a team as a code owner November 5, 2020 15:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2020
anguillanneuf
anguillanneuf approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that shutdown is clean with samples. Thanks.

@dpcollins-google dpcollins-google merged commit 7735d2f into master Nov 5, 2020
@anguillanneuf anguillanneuf deleted the warning_fixes branch November 5, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpcollins-google @anguillanneuf