fix: Make public API more similar to generated clients #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
dpcollins-google
added
the
do not merge
anguillanneuf
requested changes
Oct 27, 2020
There was a problem hiding this comment.
This largely works. What's left are:
- Clean up module imports so AdminClient, PublisherClient, and SubscriberClient can be directly imported from google.cloud.pubsublite.
- Fix
ValueError: ClientOptions does not accept an option 'x-goog-pubsub-context'. I came across this one while trying out publish. assert self._close_callback is not Nonein Line 78google/cloud/pubsublite/cloudpubsub/internal/subscriber_impl.pyfailed while I was trying out subscribe.- Add tests.
- Add documentation.
I'm not able to publish or subscribe successfully due to these bugs, but if we can get the library working, I think we are good..
google/cloud/pubsublite/cloudpubsub/internal/multiplexed_async_publisher_client.py
Outdated
Show resolved
Hide resolved
|
|
|
Thank you for all the fixes. I will test it out with samples on Monday. |
anguillanneuf
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Fixes #45
The publisher and subscriber client creation looks good and works in samples.
The remaining issue about suppressing exceptions during subscriber shutdown will be addressed in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45