Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix circular import due to make_admin_client and AdminClient being in the same file #34

Merged
merged 1 commit into from Oct 2, 2020
Merged

fix: Fix circular import due to make_admin_client and AdminClient being in the same file #34

merged 1 commit into from Oct 2, 2020

Conversation

dpcollins-google
Copy link
Collaborator

fix: Fix circular import due to make_admin_client and AdminClient being in the same file

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 2, 2020 17:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
anguillanneuf
anguillanneuf approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested doing these imports with this PR and they worked:

from google.cloud.pubsublite import make_admin_client
from google.cloud.pubsublite.cloudpubsub.make_publisher import make_publisher

@anguillanneuf anguillanneuf merged commit d631626 into master Oct 2, 2020
@anguillanneuf anguillanneuf deleted the fix-circular branch October 2, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpcollins-google @anguillanneuf