Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: surface ReservationPath and Reservation #274

Merged
merged 5 commits into from Nov 30, 2021
Merged

feat: surface ReservationPath and Reservation #274

merged 5 commits into from Nov 30, 2021

Conversation

anguillanneuf
Copy link
Collaborator

@anguillanneuf anguillanneuf commented Nov 16, 2021 •
edited

  • Surface Reservation and ReservationPath
  • Reorder types

@anguillanneuf anguillanneuf requested review from a team as code owners November 16, 2021 17:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Nov 16, 2021
@anguillanneuf @tseaver
Update google/cloud/pubsublite/types/__init__.py
df9a359 
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 17, 2021
@dpcollins-google dpcollins-google added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 19, 2021
@dpcollins-google
Copy link
Collaborator

Authorizing CLA: not sure why the bot doesn't like tianzi :/

dpcollins-google
dpcollins-google requested changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 29, 2021
@anguillanneuf anguillanneuf changed the title feat: surface Reservation and ReservationPath in types feat: surface ReservationPath in types Nov 29, 2021
@anguillanneuf anguillanneuf changed the title feat: surface ReservationPath in types feat: surface ReservationPath and Reservation Nov 29, 2021
@anguillanneuf anguillanneuf added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2021
@google-cla google-cla bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Nov 30, 2021
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2021
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 30, 2021
@dpcollins-google dpcollins-google added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 30, 2021
@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2021

@googlebot I consent.

@anguillanneuf anguillanneuf merged commit eb50503 into main Nov 30, 2021
@anguillanneuf anguillanneuf deleted the types branch November 30, 2021 19:26
This was referenced Nov 30, 2021
Merged
Merged
@release-please release-please bot mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@dpcollins-google dpcollins-google dpcollins-google approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anguillanneuf @dpcollins-google @tseaver @yoshi-kokoro