Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of pytype #257

Open
parthea opened this issue Oct 9, 2021 · 0 comments
Open

Update to the latest version of pytype #257

parthea opened this issue Oct 9, 2021 · 0 comments
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. type: cleanup An internal cleanup or hygiene concern.

Comments

@parthea
Copy link
Contributor

parthea commented Oct 9, 2021

Owl bot PR #251 failed the pytype check with seemingly unrelated changes. It turns out that the check passes with an older version of pytype. I've pinned pytype to version 2021.09.09 , the last version where the check passes.

Steps to reproduce

  1. Install pytype==2021.09.09
  2. Run pytype google/cloud/pubsublite/internal/constructable_from_service_account.py
Computing dependencies
Analyzing 1 sources with 0 local dependencies
ninja: Entering directory `.pytype'
ninja: no work to do.
Leaving directory '.pytype'
Success: no errors found
  1. Install pytype==2021.09.27 or a newer version of pytype
  2. Run pytype google/cloud/pubsublite/internal/constructable_from_service_account.py
Computing dependencies
Analyzing 1 sources with 0 local dependencies
ninja: Entering directory `.pytype'
[1/1] check google.cloud.pubsublite.internal.constructable_from_service_account
FAILED: /usr/local/google/home/partheniou/git/python-pubsublite/.pytype/pyi/google/cloud/pubsublite/internal/constructable_from_service_account.pyi 
/usr/local/google/home/partheniou/.pyenv/versions/3.9.2/envs/test1/bin/python -m pytype.single --imports_info /usr/local/google/home/partheniou/git/python-pubsublite/.pytype/imports/google.cloud.pubsublite.internal.constructable_from_service_account.imports --module-name google.cloud.pubsublite.internal.constructable_from_service_account -V 3.9 -o /usr/local/google/home/partheniou/git/python-pubsublite/.pytype/pyi/google/cloud/pubsublite/internal/constructable_from_service_account.pyi --analyze-annotated --nofail --quick /usr/local/google/home/partheniou/git/python-pubsublite/google/cloud/pubsublite/internal/constructable_from_service_account.py
File "/usr/local/google/home/partheniou/git/python-pubsublite/google/cloud/pubsublite/internal/constructable_from_service_account.py", line 30, in from_service_account_file: Invalid keyword argument credentials to function ConstructableFromServiceAccount.__init__ [wrong-keyword-args]
         Expected: (self)
  Actually passed: (self, credentials)

For more details, see https://google.github.io/pytype/errors.html#wrong-keyword-args
ninja: build stopped: subcommand failed.
Leaving directory '.pytype'
@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label Oct 9, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant