feat: Implement CPS non-asyncio subscriber #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
dpcollins-google
force-pushed
the
cps_no_asyncio
branch
from
7bf69c1
to
eac5b04
Compare
manuelmenzella-google
approved these changes
Sep 25, 2020
| pass | ||
| self._event_loop.submit(self._underlying.__aexit__(exc_type, exc_value, traceback)).result() | ||
| self._event_loop.__exit__(exc_type, exc_value, traceback) | ||
| assert self._close_callback is not None |
There was a problem hiding this comment.
IIUC, we will fail if close_callback is None. I'd personally make this optional, but if you choose not to do this, can you document this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CPS subscriber that takes a message callback and returns a StreamingPullFuture.