Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Increment ack generation id #203

Merged
merged 2 commits into from Aug 4, 2021
Merged

fix: Increment ack generation id #203

merged 2 commits into from Aug 4, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Aug 2, 2021 •
edited

Increment the ack generation id correctly. ++ does not increment in Python.

@tmdiep
fix: Increment ack generation id
1bcd72b 
Also handle duplicate acks.
@tmdiep tmdiep requested review from a team as code owners August 2, 2021 10:39
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Aug 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2021
dpcollins-google
dpcollins-google requested changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoring duplicate acks is not correct. The cloud Pub/Sub Library fails on duplicate acks

@dpcollins-google dpcollins-google merged commit 644163d into googleapis:master Aug 4, 2021
@tmdiep tmdiep deleted the fix_single_subscriber branch August 6, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpcollins-google dpcollins-google dpcollins-google approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmdiep @dpcollins-google