Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle out of band seeks #158

Merged
merged 5 commits into from Jun 11, 2021
Merged

feat: Handle out of band seeks #158

merged 5 commits into from Jun 11, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 9, 2021

Handles RESET signal (out of band seek notification) from the server by:

  • Discarding undelivered messages. Discarding outstanding acks for delivered messages.
  • Waiting for the committer to flush pending commits and receive the acknowledgment from the server.
  • Resetting all committer and subscriber state.

Sets the InitialSubscribeRequest.initial_location field when reconnecting subscribe streams.

@tmdiep tmdiep requested a review from a team as a code owner June 9, 2021 07:13
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Jun 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2021
@dpcollins-google
Copy link
Collaborator

Approved contingent on fixes.

@tmdiep tmdiep requested a review from a team as a code owner June 11, 2021 01:36
@snippet-bot
Copy link

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tmdiep tmdiep merged commit 77db700 into googleapis:master Jun 11, 2021
@tmdiep tmdiep deleted the admin_seek branch June 11, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants