Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace unreleased InitialSubscribeRequest initial_cursor field with initial_location #150

Merged
merged 1 commit into from Jun 5, 2021
Merged

fix: Replace unreleased InitialSubscribeRequest initial_cursor field with initial_location #150

merged 1 commit into from Jun 5, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented May 24, 2021 •
edited by parthea

PiperOrigin-RevId: 375562697

Source-Link: googleapis/googleapis@c71311c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f125efa59dcd62a71ee7766f14102bfdc012b36

This change was originally a breaking change. I removed the exclamation point ! from the conventional commit message because this feature is unreleased.

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 24, 2021 23:46
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label May 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@parthea parthea force-pushed the owl-bot-14672930-257a-4b3b-9df2-b9adfa2180dd branch from e90889d to 71fc69a Compare June 2, 2021 14:18
@google-cla
Copy link

google-cla bot commented Jun 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 2, 2021
@parthea parthea changed the title fix!: Replace unreleased InitialSubscribeRequest initial_cursor field with initial_location fix: Replace unreleased InitialSubscribeRequest initial_cursor field with initial_location Jun 2, 2021
@parthea
Copy link
Contributor

parthea commented Jun 2, 2021

@googlebot I consent.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 2, 2021
@parthea
Copy link
Contributor

parthea commented Jun 2, 2021

Blocked by #148

@dpcollins-google
Copy link
Collaborator

owlbot:run

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 2, 2021
@parthea
Copy link
Contributor

parthea commented Jun 2, 2021

@dpcollins-google Please can you review/approve? The samples failures look unrelated.

The owlbot:run label will signal owl bot to run. Looking at the checks for this PR, it ran successfully.

@parthea
Copy link
Contributor

parthea commented Jun 2, 2021

There is an open pull request to add the owlbot:run label to all repos:
googleapis/repo-automation-bots#1925

@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@tmdiep tmdiep merged commit 30fcd3f into master Jun 5, 2021
@tmdiep tmdiep deleted the owl-bot-14672930-257a-4b3b-9df2-b9adfa2180dd branch June 5, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmdiep tmdiep tmdiep approved these changes

@dpcollins-google dpcollins-google Awaiting requested review from dpcollins-google

Assignees

@dpcollins-google dpcollins-google

Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@parthea @dpcollins-google @tmdiep @yoshi-kokoro