Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change type hint on callback to be Callback. #135

Merged
merged 1 commit into from May 5, 2021

Conversation

dpcollins-google
Copy link
Collaborator

The overrides library doesn't like the Callable type and breaks.

mkorpela/overrides#78

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

The overrides library doesn't like the Callable type and breaks.

mkorpela/overrides#78
@dpcollins-google dpcollins-google requested a review from a team as a code owner May 5, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label May 5, 2021
Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the TODOs.

@dpcollins-google dpcollins-google merged commit cbf16f8 into master May 5, 2021
@dpcollins-google dpcollins-google deleted the fix-subscriber-type-hints branch May 5, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants