feat: Implement committer #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also small fix to retrying connection so it doesn't leak reads/writes from previous connections.
pradn
approved these changes
Sep 10, 2020
|
|
||
| class Committer(AsyncContextManager): | ||
| """ | ||
| A Committer is able to commit subscribers completed offsets. |
| await self._stop_loopers() | ||
| await connection.write(StreamingCommitCursorRequest(initial=self._initial)) | ||
| response = await connection.read() | ||
| if "initial" not in response: |
There was a problem hiding this comment.
Ideally we're not doing substrings to check for errors? This happens in a few places.
There was a problem hiding this comment.
This isn't substrings.... its checking for a subfield in the response. This is how you're supposed to check for oneof field presence in the new proto lib.
google-cla
bot
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also small fix to retrying connection so it doesn't leak reads/writes from previous connections.